Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an Override Flag for Advanced Flow Settings in Designs #1135

Merged
merged 7 commits into from
Jan 14, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change test to reflect DCP load behavior
Signed-off-by: Chris Lavin <[email protected]>
clavin-xlnx committed Jan 11, 2025
commit c095093d5f9a70b857b10dd18b9cc6938aadfb30
6 changes: 2 additions & 4 deletions test/src/com/xilinx/rapidwright/design/TestDCPWrite.java
Original file line number Diff line number Diff line change
@@ -73,7 +73,8 @@ public void testAdvancedFlowFlags(@TempDir Path tempDir) {
design.writeCheckpoint(setFalseDCPPath);

Design falseDCP = Design.readCheckpoint(setFalseDCPPath);
Assertions.assertFalse(falseDCP.isAdvancedFlow());
// Write DCP should revert flag to default case (true)
Assertions.assertTrue(falseDCP.isAdvancedFlow());

falseDCP.setAdvancedFlow(true);

@@ -82,8 +83,5 @@ public void testAdvancedFlowFlags(@TempDir Path tempDir) {
Path overrideDCPPath = tempDir.resolve("override.dcp");
Assertions.assertTrue(falseDCP.isAdvancedFlow());
falseDCP.writeCheckpoint(overrideDCPPath);

Design overrideDCP = Design.readCheckpoint(overrideDCPPath);
Assertions.assertFalse(overrideDCP.isAdvancedFlow());
}
}