-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS: Add tag
for DnsServerObject
#4515
Conversation
个人感觉把原来的改叫defaultTag,每个dnsServerObj就叫tag似乎更直观 不过其实都叫tag也无所谓 |
原字段就留着吧 querystrategy也没见改名 |
然后有可能本来没设全局的tag,现在给某个server打了,这时override谁了 叫啥都行,功能有了就行,我没代码洁癖无所谓 反正都得看文档 |
默认是个空tag |
Please add "tagOverride" and "allowUnexpectedIPs" to the documentation: https://xtls.github.io/config/dns.html#dnsserverobject Also, "queryStrategy" (for DnsServerObject) has not been added to the documentation yet !!! |
I also saw dotless: for domain-rule in the code. Xray-core/infra/conf/router.go Line 428 in 6a211a0
Line 275 in 6a211a0
But there is no such thing in the documentation. Why? |
很多代码都是v2fly继承来的 文档也是 有的v2fly未在文档列出的功能就一直没人管 这种东西已经清理了一些了不知道还有多少 不用每个都打个小报告 你要是觉得很有用可以提PR加上去 |
有了最近的俩DNS相关的Pull 下面还有俩问题:
我能想到的就是加一个开关,允许直接把目标ip强行改写,当目标本来就是个ip时 关于这个需求,目前我的补丁用着没发现什么问题
|
应当就叫
路由拿它当 inbound tag 来匹配就算是 |
好吧 done |
The timeout for each dns is fixed and is 4 seconds. Xray-core/app/dns/nameserver.go Line 183 in 6a211a0
For some types of dns like doh+fragment, this value may not be enough, but for some other types of dns like local-udp, it is too much! Also, if we want to use fallback, this value is too much. suppose, for example, we have two fallbacks other than the main dns, so it takes 8 seconds to use the second fallback !!! So the user should be able to decrease or increase this timeout. So if you agree, add the "timeout" option to this PR as well. |
And what about this? |
close #4505
字面意思 每个服务器新加了一个tagOverride参数 允许为每个dnserver指定inbound tag
为什么叫 tagOverride 不就叫tag?
因为我怕被误解成这个规则本身的tag 但是ray里并没有标识不同dnsserver的tag并按其处理的机制 这样会造成误解
不是说我赞成那个issue里谁的想法 只是全局的dns inbound tag确实是劣质的