Sockopt: Fix Windows UDP interface bind; Allow customSockopt work for UDP
#4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我记得之前我们讨论过，link 你还能找到吗 |
|
windows sockopt我记得我应该没参与 这个是draft的原因是xq说还是没用 估计还得看 |
|
OKK 没有问题了 |
RPRX
reviewed
Mar 21, 2025
|
network放到1？ |
|
话说这个 network 就是为了区分 v4 和 v6？有必要吗 |
|
我感觉既然 level 已经区分了 tcp 和 udp，如果再用个 network 来区分会有点乱，可以改成只区分 v4 v6 |
|
等下，好像也不重复，如果 |
对着udp socket操作类似tfo这样的东西大概会刷堆err log, syscall可不认识level 它只会把这几个整数抛给系统然后还个err回来 |
RPRX
changed the title
interface bind, Allow customSockopt work in UDP
RPRX
changed the title
interface bind, Allow customSockopt work in UDPinterface bind, Allow customSockopt work for UDP
RPRX
changed the title
interface bind, Allow customSockopt work for UDPinterface bind; Allow customSockopt work for UDP
|
用逗号分隔还是有点怪，以后用分号吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
字面意思 老的代码里对ipv4的判断只使用了tcp4 导致udp4漏判进入v6处理流程
以及很久之前提到的 customSockopt 移出 isTCPSocket 作用区允许它操作udp
作为扩展 新增了一个network选项为 customSockopt 指定它需要操作的网络栈