Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.0 release #2896

Merged
merged 3 commits into from
Feb 14, 2025
Merged

4.2.0 release #2896

merged 3 commits into from
Feb 14, 2025

Conversation

khancode
Copy link
Collaborator

High Level Overview of Change

4.2.0 release

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update HISTORY.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Copy link

coderabbitai bot commented Feb 14, 2025

Warning

Rate limit exceeded

@khancode has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 54 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 3fff6e0 and 413c940.

📒 Files selected for processing (1)
  • packages/xrpl/HISTORY.md (1 hunks)

Walkthrough

This pull request updates release notes and version numbers in the ripple-binary-codec and xrpl packages. The HISTORY.md files now include new release entries with support for the AMMClawback (XLS-73) and Permissioned Domains (XLS-80) amendments, alongside additional updates in the xrpl package such as a new utility function and RPC support. Corresponding package.json files have been updated to reflect these version changes and dependencies.

Changes

Files Summary
packages/ripple-binary-codec/HISTORY.md
packages/ripple-binary-codec/package.json
Added a new release entry (v2.3.0) with support for AMMClawback (XLS-73) and Permissioned Domains (XLS-80) in HISTORY.md; updated version in package.json from 2.2.0 to 2.3.0.
packages/xrpl/HISTORY.md
packages/xrpl/package.json
Introduced a new release section in HISTORY.md (v4.1.0) highlighting amendments including AMMClawback (XLS-73), Permissioned Domains (XLS-80), Deep-Freeze (XLS-77d), and the new convertTxFlagsToNumber utility (deprecating setTransactionFlagsToNumber); bumped version in package.json from 4.1.0 to 4.2.0 and updated the dependency on ripple-binary-codec.

Possibly related PRs

Suggested reviewers

  • mvadari
  • achowdhry-ripple
  • pdp2121

Poem

I'm a cheerful bunny, hopping with glee,
Codes and amendments set my hops free.
New versions twirl like leaves in the breeze,
Amending flags and domains with ease.
A nibble of updates makes my heart sing—
Happy hops in every little string! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@khancode khancode requested a review from pdp2121 February 14, 2025 01:32
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35e40d9 and 3fff6e0.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • packages/ripple-binary-codec/HISTORY.md (1 hunks)
  • packages/ripple-binary-codec/package.json (1 hunks)
  • packages/xrpl/HISTORY.md (1 hunks)
  • packages/xrpl/package.json (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/ripple-binary-codec/package.json
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: snippets (20.x)
  • GitHub Check: snippets (18.x)
  • GitHub Check: Socket Security: Pull Request Alerts
🔇 Additional comments (3)
packages/xrpl/package.json (1)

3-3: LGTM! Version updates are consistent.

The version bump to 4.2.0 and the ripple-binary-codec dependency update to ^2.3.0 align with the changes documented in the HISTORY.md files.

Also applies to: 32-32

packages/ripple-binary-codec/HISTORY.md (1)

5-9: LGTM! Release notes are well documented.

The release notes for version 2.3.0 clearly document the support for two new amendments:

  • AMMClawback amendment (XLS-73)
  • Permissioned Domains amendment (XLS-80)
packages/xrpl/HISTORY.md (1)

16-20: LGTM! Changes are well documented.

The changes section clearly documents:

  • Deprecation of setTransactionFlagsToNumber with migration path to convertTxFlagsToNumber
  • Fix for network_id field in the server_state response interface

@@ -14507,7 +14507,7 @@
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we place the package-lock.json file under .gitignore ? It's diff should not be pushed into remotes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the root package-lock.json should be updated so this change is correct.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, other developers can always do npm install inside the repository root. Do we need to push this lock file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required because package-lock.json installs the exact, versioned dependency tree rather than using starred versioning. Starred versioning can install newer versions of packages that can potentially break the project.

@khancode khancode requested a review from ckeshava February 14, 2025 01:51
@khancode khancode merged commit 5b16d0c into main Feb 14, 2025
16 checks passed
@khancode khancode deleted the 4.2.0-release branch February 14, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants