-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paragraph block: migrate text align and add full wide supports #69586
base: trunk
Are you sure you want to change the base?
Paragraph block: migrate text align and add full wide supports #69586
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @SilasOtoko, @james-s-k, @patrickwc, @kaelansmith, @nickfmc. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do not create a new hook and delete the class name, the fixCustomClassname
process will run and class names such as has-text-align-center
will remain in the additional CSS classes.
...block, | ||
attributes: updatedBlockAttributes, | ||
}; | ||
|
||
return applyFilters( | ||
'blocks.applyBuiltInValidationFixes', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hook is necessary to handle deprecation from stored content.
It is useful when handling deprecation from stored content.
What?
Closes #31429
Paragraph block migrate text align and add full wide supports
Why?
Heading blocks have wide and full, but paragraph blocks do not.
There didn't seem to be any negative comments in the issue, so I made the adjustment.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
before.mp4
After
after.mp4