Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph block: migrate text align and add full wide supports #69586

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

shimotmk
Copy link
Contributor

What?

Closes #31429

Paragraph block migrate text align and add full wide supports

Why?

Heading blocks have wide and full, but paragraph blocks do not.
There didn't seem to be any negative comments in the issue, so I made the adjustment.

How?

Testing Instructions

  1. Open a post or page.
  2. Insert a Paragraph block.
  3. You can see that the toolbar allows you to set the text alignment to full width, wide, and so on.

Testing Instructions for Keyboard

Screenshots or screencast

Before

before.mp4

After

after.mp4

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @SilasOtoko, @james-s-k, @patrickwc, @kaelansmith, @nickfmc.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: SilasOtoko, james-s-k, patrickwc, kaelansmith, nickfmc.

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: paaljoachim <[email protected]>
Co-authored-by: silvanarnet <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do not create a new hook and delete the class name, the fixCustomClassname process will run and class names such as has-text-align-center will remain in the additional CSS classes.

...block,
attributes: updatedBlockAttributes,
};

return applyFilters(
'blocks.applyBuiltInValidationFixes',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hook is necessary to handle deprecation from stored content.

It is useful when handling deprecation from stored content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wide and full alignment for paragraph block may be needed again.
1 participant