Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix worse lower bound than incumbent #36

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

Wikunia
Copy link
Owner

@Wikunia Wikunia commented May 8, 2022

Only add a new solution if it can produce better results than the current incumbent.
Also if the lower bound is worse after evaluating the node we don't want to falsely update the lower bound such that it looks like the lower bound is worse than the incumbent

@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #36 (c3d45a9) into main (d226392) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c3d45a9 differs from pull request most recent head 98c2b18. Consider uploading reports for the commit 98c2b18 to get more accurate results

@@            Coverage Diff            @@
##              main       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          127       128    +1     
=========================================
+ Hits           127       128    +1     
Impacted Files Coverage Δ
src/Bonobo.jl 100.00% <100.00%> (ø)
src/node.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d226392...98c2b18. Read the comment docs.

@matbesancon
Copy link
Contributor

Only add a new solution if it can produce better results than the current incumbent.

depends, one could want to store multiple solutions as discussed another issue, but the first / last one should always be the best solution yes

@Wikunia
Copy link
Owner Author

Wikunia commented Jun 15, 2022

Here it's more about adding a new node only if it can produce results better than the current incumbent.

@matbesancon
Copy link
Contributor

alright then looks good

@matbesancon
Copy link
Contributor

should we merge this?

@Wikunia Wikunia merged commit 0f45661 into main Jul 21, 2022
@Wikunia Wikunia deleted the bugfix-lb-higher-than-incumbent branch July 21, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants