Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New license #24

Merged
merged 4 commits into from
Oct 18, 2019
Merged

New license #24

merged 4 commits into from
Oct 18, 2019

Conversation

keeeto
Copy link
Member

@keeeto keeeto commented Sep 25, 2019

License change

Reviewers

I have added all contributors as reviewers - you just need to state that you are happy to have the license change. Feel free to dig deeper into the changes, but a record of your agreement to the change is the most important thing! Thanks.

As agreed with the developers of smact this PR changes from GPL to MIT license.

  • The LICENSE file has been changed
  • GPL headers have been removed from all code files (no replacement is required for MIT)
  • Reference to the elements.txt file from OpenBabel has been removed as we no longer use this file. The GPL 2 license associated with this has been removed.

To test

No functional testing required. Please just check that license files have been changed where you would expect. Also, please confirm what I said about OpenBabel and GPL2.

Copy link
Member

@ajjackson ajjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to switch to MIT, as previously discussed.

I confirm that the periodic table data is no longer from OpenBabel, it was rebuilt from the data sources cited in the header.

Requested changes

  • The license file still contains placeholders for [year] and [fullname], those should be filled in.
  • License type should be updated in setup.py

@keeeto
Copy link
Member Author

keeeto commented Sep 25, 2019

Good point. Who should go in full name? All contributors to date?

@jarvist
Copy link
Member

jarvist commented Sep 25, 2019

Sometimes you just have e.g. 'The Smact Developers' to go in as a name in the license, then some list elsewhere.

Also, I confirm I'm happy for the re-license!

@keeeto
Copy link
Member Author

keeeto commented Sep 25, 2019

That's a good idea Jarv. I might add a developers file to the repo.

@keeeto keeeto requested review from a-ws-m and JMSkelton September 25, 2019 09:02
Copy link
Member

@dandavies99 dandavies99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [year] and [name] placeholders in LICENCE have now been updated to "2019 The SMACT Developers" and an accompanying list of developers has been added to the README.

@dandavies99 dandavies99 merged commit 379bae7 into master Oct 18, 2019
@dandavies99 dandavies99 deleted the new_license branch October 29, 2019 15:03
@coderabbitai coderabbitai bot mentioned this pull request Jan 14, 2025
10 tasks
@coderabbitai coderabbitai bot mentioned this pull request Feb 25, 2025
This was referenced Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants