-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New license #24
New license #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to switch to MIT, as previously discussed.
I confirm that the periodic table data is no longer from OpenBabel, it was rebuilt from the data sources cited in the header.
Requested changes
- The license file still contains placeholders for [year] and [fullname], those should be filled in.
- License type should be updated in setup.py
Good point. Who should go in full name? All contributors to date? |
Sometimes you just have e.g. 'The Smact Developers' to go in as a name in the license, then some list elsewhere. Also, I confirm I'm happy for the re-license! |
That's a good idea Jarv. I might add a developers file to the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The [year] and [name] placeholders in LICENCE have now been updated to "2019 The SMACT Developers" and an accompanying list of developers has been added to the README.
License change
Reviewers
I have added all contributors as reviewers - you just need to state that you are happy to have the license change. Feel free to dig deeper into the changes, but a record of your agreement to the change is the most important thing! Thanks.
As agreed with the developers of
smact
this PR changes from GPL to MIT license.elements.txt
file fromOpenBabel
has been removed as we no longer use this file. The GPL 2 license associated with this has been removed.To test
No functional testing required. Please just check that license files have been changed where you would expect. Also, please confirm what I said about
OpenBabel
and GPL2.