Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): new focus style (VIV-2350) #2186

Merged
merged 24 commits into from
Apr 1, 2025
Merged

Conversation

rachelbt
Copy link
Contributor

@rachelbt rachelbt commented Mar 4, 2025

  • waiting for design approval to generate new png's

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (7425ed8).
Report is 1379 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main     #2186      +/-   ##
============================================
  Coverage   100.00%   100.00%              
============================================
  Files          123       375     +252     
  Lines         1562     16770   +15208     
  Branches       108      2942    +2834     
============================================
+ Hits          1562     16770   +15208     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

⚠️ The generated metadata has changed. I have updated the metadata file for you. Please review the changes:

View Diff
5756c5756,5765
< 				{ "name": "selectionStartChanged", "args": [], "returnType": "unknown" }
---
> 				{
> 					"name": "selectionStartChanged",
> 					"args": [],
> 					"returnType": "unknown"
> 				},
> 				{
> 					"name": "setTextSize",
> 					"args": [{ "name": "size", "type": "'title' | 'subtitle' | 'body'" }],
> 					"returnType": "unknown"
> 				}

@rachelbt rachelbt merged commit 45dc79e into main Apr 1, 2025
17 checks passed
@rachelbt rachelbt deleted the VIV-2350-focus-style branch April 1, 2025 10:12
@github-actions github-actions bot mentioned this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants