Add headers configuration #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it :) We should test this, right? |
|
Yeah we should test it. In order to do this, we have to introduce a method to get the guzzleClient in order to test the headers against the Url object right ? |
|
@eljam yes :) Exactly! :) |
|
@mmoreram can we drop guzzle 4 as it's not maintained anymore ? |
eljam
force-pushed
the
add-header-configuration
branch
from
77231cb to
79c102d
Compare
|
@mmoreram any update :) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a good way to add headers in the library ? @mmoreram