setup.py: fix requirements #288
Conversation
blueyed
force-pushed
the
fix-reqs
branch
3 times, most recently
from
9f4415b to
84c8f64
Compare
|
I think requirements.txt could also be moved into setup.py - but left it for now. |
|
I think this warrants a 0.3.x release already, since people are having problems with it everywhere already. |
- use tox-travis - upload to codecov - test py35, py36
Hopefully fixes UnicodeDecodeError [1]. 1: https://travis-ci.org/Kuniwak/vint/jobs/404029681#L702
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
=========================================
Coverage ? 70.77%
=========================================
Files ? 133
Lines ? 7737
Branches ? 1252
=========================================
Hits ? 5476
Misses ? 1932
Partials ? 329 |
|
@blueyed I appreciate to your contributing. I have not tested for reproducing but I have a question about why past tests on Python 2.7 were not failed by the cause. In my first look, I think your changes actually do the same thing like the previous code. Would you explain how work your fix? |
have not checked myself The main problem is that the conditionals only get executed when running |
|
I think this is good from my side. |
.travis.yml
Outdated
|
|
||
| install: | ||
| - pip install tox | ||
| - if test "$TOXENV" = "coverage"; then pip install coveralls; fi | ||
| - pip install tox tox-travis pytest-cov |
There was a problem hiding this comment.
pytest-cov would not be necessary here. But could maybe get removed from testing requirements?!
| @@ -1,17 +1,9 @@ | |||
| [tox] | |||
| envlist = py27, py34, coverage | |||
| envlist = py27, py36 | |||
There was a problem hiding this comment.
This list gets used when using just ´tox` locally, so I have not listed all envs there.
@blueyed Sounds good. And keeping the requirements.txt file (it will become to be empty) may be good to old users. Because previous installation instructions are using requirements.txt. |
|
@blueyed I'm planning that releasing this fix at both 0.3.20 and 0.4a2. How do you feel it? |
|
@Kuniwak Would be good to ensure that the built wheels are working as expected though - when being built locally and installed in different Python versions. |
It is always failing, not worth fixing for now. Ref: Vimjas/vint#288 Ref: Vimjas/vint#287
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This gets installed through/in tox already. Ref: Vimjas#288 (comment)
|
Pushed a few commits. |
|
Updates? |
|
No, it seems like @Kuniwak went missing.. :/ I could merge this myself, but would like to get more eyes on this first. |
Fixes #287
Please review carefully.
Based on pytest's setup.py, which supports different marker levels, but I hope we do not need that: https://github.com/pytest-dev/pytest/blob/master/setup.py.