Using Vc as CMake subproject #188
Comments
|
For the 1.4 branch at least, the |
milianw
added a commit
to milianw/Vc
that referenced
this issue
Dec 18, 2018
This patch adds a Vc_submodule.cmake which can be included by a CMake parent project. This builds the Vc target and sets the corresponding compiler flags on Vc. The flags are also published through the target to all consumers of it. So basically all you need to do now is: ``` include(Vc/Vc_submodule.cmake) add_executable(foo ...) target_link_libraries(foo Vc) ``` The submodule file tries not to pollute the global CMake properties. I.e. CMAKE_CXX_FLAGS is reset to the previous value. CMAKE_BUILD_TYPE is also not touched by default - if that is preferred, consumers need to `set(USE_VC_BUILDTYPE_FLAGS ON)`. This patch fixes VcDevel#188 for the 1.4 branch.
milianw
added a commit
to milianw/Vc
that referenced
this issue
Dec 18, 2018
This patch adds a Vc_submodule.cmake which can be included by a CMake parent project. This builds the Vc target and sets the corresponding compiler flags on Vc. The flags are also published through the target to all consumers of it. So basically all you need to do now is: ``` include(Vc/Vc_submodule.cmake) add_executable(foo ...) target_link_libraries(foo Vc) ``` The submodule file tries not to pollute the global CMake properties. I.e. CMAKE_CXX_FLAGS is reset to the previous value. CMAKE_BUILD_TYPE is also not touched by default - if that is preferred, consumers need to `set(USE_VC_BUILDTYPE_FLAGS ON)`. This patch fixes VcDevel#188 for the 1.4 branch.
milianw
added a commit
to milianw/Vc
that referenced
this issue
Dec 19, 2018
This patch adds a Vc_submodule.cmake which can be included by a CMake parent project. This builds the Vc target and sets the corresponding compiler flags on Vc. The flags are also published through the target to all consumers of it. So basically all you need to do now is: ``` include(Vc/Vc_submodule.cmake) add_executable(foo ...) target_link_libraries(foo Vc) ``` The submodule file tries not to pollute the global CMake properties. I.e. CMAKE_CXX_FLAGS is reset to the previous value. CMAKE_BUILD_TYPE is also not touched by default - if that is preferred, consumers need to `set(USE_VC_BUILDTYPE_FLAGS ON)`. This patch fixes VcDevel#188 for the 1.4 branch.
|
Fixed by #271. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
This is slightly related to #184, but seeing as I have a concrete use case in mind, I decided to put it into a different issue.
I like the simd proposal and my project is in development state, so I'm OK with using unstable master branch. Git submodules seem like the easiest solution. I'm also using CMake, so my hope was that a simple
add_subdirectoryshould suffice. This brings me to the problem.Problem
CMakelists.txt in Vc root directory uses
CMAKE_SOURCE_DIR:https://github.com/VcDevel/Vc/blob/master/CMakeLists.txt#L8
https://github.com/VcDevel/Vc/blob/master/CMakeLists.txt#L185
https://github.com/VcDevel/Vc/blob/master/CMakeLists.txt#L312
This means that if I have Vc cloned somewhere in
myproject/external/Vc, Vc's CMakelists.txt will search for Vc-specific CMake modules inmyproject/cmakerather thanmyproject/external/Vc/cmake. UsingCMAKE_CURRENT_SOURCE_DIRin all three places seems to solve the problem.Again, I can create a small PR if you like.
Thanks,
Tom
The text was updated successfully, but these errors were encountered: