Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix admin panel build warning on i18.ts #259

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

stonecobra
Copy link
Contributor

npm run cf:build with a clean repo gives a warning during the build:

[next-intl] Reading request configuration from ./i18n.ts is deprecated, please see https://next-intl.dev/blog/next-intl-3-22#i18n-request — you can either move your configuration to ./i18n/request.ts or provide a custom path in your Next.js config:

const withNextIntl = createNextIntlPlugin(
  './path/to/i18n/request.tsx'
);

As we are only pulling the locale, this patch fixes that and removes the deprecation warning.

@byn9826
Copy link
Member

byn9826 commented Mar 11, 2025

Thanks for bring this up, but looks like you are replacing locale with requestLocale, not really related to the "Reading request configuration from ./i18n.ts is deprecated" issue. When I'm testing on my locale this issue still persist, same thing in the pipeline as well https://github.com/ValueMelody/melody-auth/actions/runs/13751133632/job/38532160703?pr=259.

Can you take another look if you are interested

@byn9826
Copy link
Member

byn9826 commented Mar 13, 2025

https://next-intl.dev/blog/next-intl-3-22#await-request-locale

Merge as this deals with a separated issue might raise with Next.js 15

@byn9826 byn9826 merged commit e9e9b29 into ValueMelody:main Mar 13, 2025
1 check passed
@byn9826
Copy link
Member

byn9826 commented Mar 13, 2025

#263 will fix the issue in description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants