Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resend.com to supported mail providers #244

Merged
merged 7 commits into from
Feb 25, 2025

Conversation

luizfonseca
Copy link
Contributor

@luizfonseca luizfonseca commented Feb 22, 2025

Hello 👋🏽

As mentioned on #236, this PR adds support to use https://resend.com as one of the email providers.

Users will need to follow the required setup to enable it (e.g. adding their domains to resend and so on)

Tested with ENVIRONMENT = 'prod'

This PR:

  • Adds the ResendMailer
  • Adds the current test coverage to resend as well
  • Updated docs
Screenshot 2025-02-23 at 00 23 53

@luizfonseca
Copy link
Contributor Author

In a related note, might be easier to split the email tests into different files in the future so we don't need to reset the process.env.* after each test run (also making it easier to test others if necessary)

@luizfonseca luizfonseca changed the title Add resend.com to support mail providers Add resend.com to supported mail providers Feb 22, 2025
@luizfonseca luizfonseca changed the title Add resend.com to supported mail providers Add resend.com to supported mail sending providers Feb 22, 2025
@luizfonseca luizfonseca changed the title Add resend.com to supported mail sending providers Add resend.com to supported mail providers Feb 22, 2025
@@ -18,6 +18,8 @@ Use the table below to configure your chosen email provider. Some variables are
| MAILGUN_SENDER_ADDRESS | Sender email address in Mailgun (Required if you intend to use Mailgun) | "[email protected]" |
| BREVO_API_KEY | Your Brevo API key (Required if you intend to use Brevo) | "xkeysib-xxxxxxxxxxxxxxxxxxxxxxxx" |
| BREVO_SENDER_ADDRESS | Verified sender address in Brevo (Required if you intend to use Brevo) | "[email protected]" |
| RESEND_API_KEY | Your Resend.com API key (Required if you intend to use Resend.com) | "re_xxxxxxxxxxxxxxxxxxxxxxx" |
| RESEND_SENDER_ADDRESS | Verified sender address in Resend.com (Required if you intend to use Resend.com) |
| SMTP_SENDER_ADDRESS | SMTP sender email address (Node.js only) | "[email protected]" |
| SMTP_CONNECTION_STRING | SMTP connection string (Node.js only) | "smtp://username:[email protected]:587" |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the "## Priority Between Providers" section, and add a test case for it as well

Copy link
Contributor Author

@luizfonseca luizfonseca Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc updated ✅

Re: test -> do you want me to create one that explicitly tests the priority? The current one kinda covers it, but not explicitly I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byn9826
Copy link
Member

byn9826 commented Feb 23, 2025

In a related note, might be easier to split the email tests into different files in the future so we don't need to reset the process.env.* after each test run (also making it easier to test others if necessary)

Good suggestion, thank you

@byn9826 byn9826 merged commit b9176ff into ValueMelody:main Feb 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants