move __call__/assess into every variable type from core #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iferencik
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
iferencik
temporarily deployed
to
github container registry
GitHub Actions
Inactive
iferencik
changed the title
iferencik
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
iferencik
temporarily deployed
to
github container registry
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call methods was implemented one in the Variable superclass. However as @JinIgarashi pointed out it specific implementation details applicable to only population component (see force_compute) make it tricky to use this implementation in other components
As a result this PR removed the implementation from core.variable into each component/variable type.