Fix the pages being out of order #77
Conversation
Simply fixed by counting the number of entries matched against the existing predicate and inserting them into the array in a secondary loop.
|
I'm not an experienced JavaScript developer, feel free to make changes. |
There was a problem hiding this comment.
A lot of the changes in this pull request simply reformat the code. Would you mind changing your PR and keep the original lines and style?
Maybe you can also just use the code from Zotero 6 to fix the issue.
Both suggested changes would make the review easier.
|
Shall I just replace my code with the old Zotero 6 code, using await? |
|
Does this now look better @stweil? |
|
Sorry about my lack of reactivity, I have been unable to read the proposed code until yesterday. The first commit would have been easier to review without the style changes. In the 2nd one, I don't think returning to Zotero6-compatible code is the way to go. I have a much simpler fix in mind: since imageListArray is not guaranteed to be in the right order, sorting it before writing imagelist.txt should do the trick. I will push the commit in a minute, but it is best if @stweil or @zuphilip publishes the new version. |
|
Thanks again for your bug report and your efforts with this pull request. Meanwhile a different fix was applied and released in release 0.7.3, so this one here is no longer needed. |
This resolves #76.
Instead of iterating over the contents of the directory and inserting them based on a matched predicate, we count the number of matched entries and generate the paths ourselves.