[Modified] UI improvements - round 1 #138
Conversation
Update EditRuleset.xaml
UI improvements - round 1
- Use close button instead of minimize button - Revert back the sizes with slight increment to max size
| <wpfui:TitleBar | ||
| Title="Select Browser" | ||
| Height="32" | ||
| CloseClicked="HideMainWindow" | ||
| FontSize="14" | ||
| ShowMaximize="False" | ||
| ShowMinimize="False" /> |
There was a problem hiding this comment.
The problem with this solution compared to earlier one is that, the window is not easily resizable compared to previous solution. Especially from the top
There was a problem hiding this comment.
I see what you mean. Looks like WPF-UI issue lepoco/wpfui#972
| var osbuild = Environment.OSVersion.Version.Build; | ||
| var backtype = settings.AppSettings?.BackgroundType; | ||
|
|
||
| if (settings.AppSettings?.NoWhiteBorder == true) WindowBorder.BorderThickness = new Thickness(0); | ||
| if (osbuild < 22000) WindowBorder.CornerRadius = new CornerRadius(0); | ||
|
|
||
| if (backtype == "acrylic" && osbuild >= 22523) | ||
| { | ||
| WindowBackdropType = WindowBackdropType.Acrylic; | ||
| } | ||
| else if (backtype == "none" || osbuild < 22000) | ||
| { | ||
| WindowBackdropType = WindowBackdropType.None; | ||
| var brush = Color.FromRgb(150, 50, 50); | ||
| Background = new SolidColorBrush(brush); | ||
| } | ||
| else | ||
| { | ||
| WindowBackdropType = WindowBackdropType.Mica; | ||
| } |
There was a problem hiding this comment.
I still prefer to have acrylic
Might have to revert this back unfortunately, while also trying to support SystemThemeWatcher
There was a problem hiding this comment.
I agree Mica is better (reason: looks like Win Start menu uses it too)
<fluentwindow
WindowBackdropType="Mica"Is the place for this. Easy change, no need to revert :)
|
@Jay-o-Way Honestly, I am sorry, this is very harder than I imagined because there are too many changes. As I am also worried that this would lead to wasted efforts from your end, I will still try to figure out ways I can scavenge the few changes I want from this PR but for the last time and further from now on, I have to enforce that I won't merge/review any PR that is not focused on a particular change. |
| MaxHeight="450" | ||
| Deactivated="Window_Deactivated" | ||
| ExtendsContentIntoTitleBar="True" | ||
| Icon="/Windows/internet.ico" | ||
| PreviewKeyUp="Window_KeyEvents" | ||
| SizeChanged="Window_SizeChanged" | ||
| Topmost="True" | ||
| WindowBackdropType="Mica" |
There was a problem hiding this comment.
| WindowBackdropType="Mica" | |
| WindowBackdropType="Acrylic" |
| Title="Select Browser" | ||
| Height="32" | ||
| CloseClicked="HideMainWindow" | ||
| FontSize="14" |
There was a problem hiding this comment.
| Title="Select Browser" | |
| Height="32" | |
| CloseClicked="HideMainWindow" | |
| FontSize="14" | |
| Title="Select Browser" | |
| CloseClicked="HideMainWindow" |
Height and FontSize don't need to be hardcoded. There's a possibility the size isn't even implemented: lepoco/wpfui#937
| </Grid> | ||
|
|
||
| <Grid Grid.Row="2"> | ||
| <Grid Grid.Row="2" Margin="0,0,0,8"> |
There was a problem hiding this comment.
| <Grid Grid.Row="2" Margin="0,0,0,8"> | |
| <Grid Grid.Row="2"> |
| <wpfui:Button | ||
| MinWidth="120" | ||
| HorizontalAlignment="Center" | ||
| Appearance="Transparent" |
There was a problem hiding this comment.
| Appearance="Transparent" |
| <wpfui:Button | ||
| MinWidth="120" | ||
| Margin="0,0,8,0" | ||
| HorizontalAlignment="Stretch" |
There was a problem hiding this comment.
| HorizontalAlignment="Stretch" |
| Content="Create" /> | ||
| <wpfui:Button | ||
| MinWidth="120" | ||
| HorizontalAlignment="Stretch" |
There was a problem hiding this comment.
| HorizontalAlignment="Stretch" |
these have no function here
|
Introduced some changes (#140) from here, related to |
Continuation from #137 changes
EDIT: While I can't merge this, I use this as a reference ocassionally