Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for boolean-disjoint - Fixes #896 #908

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Fix for boolean-disjoint - Fixes #896 #908

merged 1 commit into from
Aug 17, 2017

Conversation

rowanwins
Copy link
Member

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

Resolves #896 with disjoint where a poly was completely contained within another poly.

@DenisCarriere DenisCarriere changed the title Fix for boolean-disjoint - Resolves #896 Fix for boolean-disjoint - Fixes #896 Aug 17, 2017
DenisCarriere
DenisCarriere approved these changes Aug 17, 2017
View reviewed changes
Copy link
Member

@DenisCarriere DenisCarriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was a pretty straightforward fix 👍

@DenisCarriere DenisCarriere added this to the 4.7.0 milestone Aug 17, 2017
@DenisCarriere DenisCarriere merged commit dad5026 into master Aug 17, 2017
@DenisCarriere DenisCarriere deleted the patch-disjoint branch August 17, 2017 17:54
@DenisCarriere DenisCarriere mentioned this pull request Sep 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenisCarriere DenisCarriere DenisCarriere approved these changes

Assignees

@rowanwins rowanwins

Labels
None yet
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanwins @DenisCarriere