Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for @turf/polygon-tangents - Resolves #785 #792

Merged
merged 2 commits into from
Jun 17, 2017
Merged

Fix for @turf/polygon-tangents - Resolves #785 #792

merged 2 commits into from
Jun 17, 2017

Conversation

rowanwins
Copy link
Member

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

Resolves issue #785 but setting properly initiating rtan and ltan as 0 as per the sample script on which the module is built

@DenisCarriere DenisCarriere added this to the 4.5.0 milestone Jun 15, 2017
@DenisCarriere
Copy link
Member

Strange, build is failing from unkink-polygon.

This PR passes locally

@DenisCarriere DenisCarriere merged commit 2b39cdd into master Jun 17, 2017
@DenisCarriere DenisCarriere deleted the fix-tangents branch June 17, 2017 18:57
@DenisCarriere DenisCarriere mentioned this pull request Jun 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rowanwins rowanwins

Labels
bug testing
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanwins @DenisCarriere