turf-destination, turf-ellipse: Fix coordinate elevation component failing to pass though. #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dimension handling in tesselate. Test for elevation in tesselate. Fix elevation in destination. Add input and output test cases with elevation to destination and ellipse.
prozvora
commented
Mar 8, 2025
packages/turf-tesselate/test.ts
Outdated
Comment on lines
3521
to
3535
| t.equal( | ||
| simpleTrianglesWithElevation.type, | ||
| "FeatureCollection", | ||
| "Polygon returns a FeatureCollection" | ||
| ); | ||
| t.equal( | ||
| simpleTrianglesWithElevation.features[0].geometry.type, | ||
| "Polygon", | ||
| "contains at least 1 triangle" | ||
| ); | ||
| t.equal( | ||
| simpleTrianglesWithElevation.features[0].geometry.coordinates[0].length, | ||
| 4, | ||
| "triangle is valid" | ||
| ); |
There was a problem hiding this comment.
not sure if these tests are necessary to repeat. I copied them from the first polygon. I figured they would catch any malformation issues from adding the elevation to the coordinate.
There was a problem hiding this comment.
removed tessellate changes, should be included in a different PR as they are more complex.
prozvora
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix elevation in destination.
Add input and output test cases with elevation to destination and ellipse.
Note
This is a non-breaking change.
Resolves
Test Output
Destination
Ellipse
Please provide the following when creating a PR:
contributorsfield ofpackage.json- you've earned it! 👏