Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website update #114

Merged
merged 6 commits into from
Jul 31, 2017
Merged

Website update #114

merged 6 commits into from
Jul 31, 2017

Conversation

stebogit
Copy link
Collaborator

@DenisCarriere @rowanwins
I corrected the @examples in @turf (PR #857 and commit 86f3c2) and ran npm run deploy, plus fixed few typos in the doc here.

Should I also add the new functions/modules to documentation.yml?

This PR contain also the updates for the www pages, generated by the deploy, am I right?

@stebogit stebogit self-assigned this Jul 27, 2017
@stebogit stebogit requested a review from rowanwins July 27, 2017 07:29
@rowanwins
Copy link
Member

Gday @stebogit

Yep that all looks fine to me so far, and yep you're right this does include the files from npm run deploy (the index.html and the static assets like the generated js and css).

I think you may as well add in the new modules and do it all in one hit.

@DenisCarriere
Copy link
Member

👍 to include the new modules, it will move along publishing the release if we see them in the Docs.

@DenisCarriere
Copy link
Member

@stebogit Noticed the assets folder was nested, seems strange, don't know what caused that:

image

Copy link
Member

@DenisCarriere DenisCarriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve nested assets folder

- removed nested assets folder;
- added new modules to documentation
- ran deploy;
- fixed deploy script;
@stebogit
Copy link
Collaborator Author

I think I did all the necessary to update the website.
I added all the new modules, which now fail running the examples; I guess this will be fixed when we'll publish the next release with those modules.

@DenisCarriere
Copy link
Member

@stebogit 👍 nice work!

@DenisCarriere DenisCarriere merged commit 15b1866 into gh-pages Jul 31, 2017
@DenisCarriere DenisCarriere deleted the deploy-fix branch July 31, 2017 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants