Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Add Flatpak build CI #99

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

TheEvilSkeleton
Copy link
Contributor

Licensing

  • I confirm that this is either my code or was released under the terms of a GPLv3-or-later compatible license. Also I agree to release it here under the terms of the GPLv3-or-later.

Description

This MR will help us test Tubefeeder flatpak without needing to manually build it. GitHub will publish artifacts that we can then download and install locally and test. This also enables us to use GNOME Builder to build it locally and launch the app without installing it.

Linked Issue

There weren't any discussion prior to opening this MR, so I completely understand if this gets closed.

Sorry, something went wrong.

@TheEvilSkeleton TheEvilSkeleton marked this pull request as ready for review October 5, 2022 20:29
@TheEvilSkeleton
Copy link
Contributor Author

@Schmiddiii I noticed you use emojis for git commit messages. GitHub has a feature that lets you squash commits, which also lets you rewrite commit messages:

image

You can use that feature to add your preferred emoji.

@Schmiddiii
Copy link
Collaborator

Schmiddiii commented Oct 6, 2022

Could we have the de.schmidhuberj.tubefeeder.json and player_downloader.diff not in the root-folder?

And I know that I can squash commits, but I do not really care about the emoji-commit-messages any more (I switched to another style for my newer projects). And this would probably un-verify your commits so I just left them.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@TheEvilSkeleton
Copy link
Contributor Author

Is under build-aux good for you? I placed everything there since it's what other GNOME apps do.

@Schmiddiii Schmiddiii merged commit 8f66c5b into Tubefeeder:master Oct 6, 2022
@TheEvilSkeleton TheEvilSkeleton deleted the flatpak-ci branch October 6, 2022 14:47
@TheEvilSkeleton
Copy link
Contributor Author

Uhh, I'm not sure why it needs network access out of nowhere...

@Schmiddiii
Copy link
Collaborator

It has to download Cargo packages from crates.io. Do you know how to fix this?

@TheEvilSkeleton
Copy link
Contributor Author

TheEvilSkeleton commented Oct 6, 2022

I think I know how to fix it, but I'm really confused with why it was working completely fine locally, but not with CI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants