-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add flatpak build via electron-forge #1130
Conversation
previously it was defaulting to an EOL version of the Platform/SDK Explicitly setting it to 24.08 however makes the build fail, because it defaults to using an outdated "zypak" module, so we need to explicitly mention the latest version here too
arm64 currently is broken due to a bug in electron-forge's maker-flatpak, but PR with a fix was submitted already
one tiny thing I still need to do there as well: kinda "hack" my fix for arm64 into the workflow, as we don't know how fast the change will land in upstream. I will commit tomorrow morning (should be a matter of a small |
currently required, because Flatpak arm64 build currently fails – and if it fails, the remaining builds (deb, rpm, zip) fail as well, as they are created in the same run. once the fix is released in the next electron-forge, we can get rid of this again.
temporary fix commited and builds fine for both x64 and arm64 on my fork :-) You can find the files here: they seem to install and work fine on my Ubuntu system: will keep an eye on the upstream PR and monitor, when it will be part of the next electron-forge release, so that we can get rid of the temporary fix again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pano9000 , we'll go for |
Hi,
this PR adds the ability to build a Flatpak package via Github CI using electron-forge.
arm64 support is currently broken, but a PR is opened at electron-forge, to fix that issue.
What we might need to agree still:
is the ID I've used here "acceptable"?
com.github.triliumnext.notes
The original Trilium was using
com.github.zadam.trilium
this closes #233