Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding latest commands from @github/copilot-language-server #236

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TerminalFi
Copy link
Owner

@TerminalFi TerminalFi commented Feb 5, 2025

Todo

  • Ability for changing model in Chat.

@jfcherng jfcherng force-pushed the feat/copilotModels branch 2 times, most recently from 467f1fd to a94ffd7 Compare February 5, 2025 17:40
@jfcherng jfcherng force-pushed the feat/copilotModels branch 2 times, most recently from f152a88 to 9ca25e4 Compare February 5, 2025 18:09
Signed-off-by: Jack Cherng <[email protected]>
@phene
Copy link

phene commented Mar 7, 2025

What's holding up the ability to change models?

@jfcherng
Copy link
Collaborator

jfcherng commented Mar 7, 2025

What's holding up the ability to change models?

#235 should be merged first.

And it has a blocker sublimehq/sublime_text#6424 (not sure whether we can workaround this in ST)

@TerminalFi
Copy link
Owner Author

@phene Yes, as @jfcherng stated, while functionality wise this works. When we switch over to the GH provided npm package it is 200+ MB and that causes ST to fail loading the files sadly. There is technically a potential work around, and that is to change how LSP looks for these files :) But I doubt they want to diverge from the build in solution.

The other option is that we can put these new commands behind a setting, and tell the user they must provide the package and update the settings.

I highly encourage you to contribute. It would be greatly appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants