-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding latest commands from @github/copilot-language-server #236
base: master
Are you sure you want to change the base?
Conversation
e8d1297
to
84d1515
Compare
Signed-off-by: Jack Cherng <[email protected]>
467f1fd
to
a94ffd7
Compare
Signed-off-by: Jack Cherng <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
f152a88
to
9ca25e4
Compare
Signed-off-by: Jack Cherng <[email protected]>
9ca25e4
to
721606f
Compare
Signed-off-by: Jack Cherng <[email protected]>
What's holding up the ability to change models? |
#235 should be merged first. And it has a blocker sublimehq/sublime_text#6424 (not sure whether we can workaround this in ST) |
@phene Yes, as @jfcherng stated, while functionality wise this works. When we switch over to the GH provided npm package it is 200+ MB and that causes ST to fail loading the files sadly. There is technically a potential work around, and that is to change how LSP looks for these files :) But I doubt they want to diverge from the build in solution. The other option is that we can put these new commands behind a setting, and tell the user they must provide the package and update the settings. I highly encourage you to contribute. It would be greatly appreciated |
Todo