Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMDb get user id from user profile - refs #119 #130

Merged

Conversation

Row
Copy link
Contributor

@Row Row commented Oct 7, 2020

Description of the Change

The div with id main has been removed. The user id is not present in the IMDb landing page, it is located in the user profile.
Fix #119

@Row
Copy link
Contributor Author

Row commented Oct 8, 2020

Hey I am participating in hacktoberfest this year so would be great if this PR counted towards the quota.

Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

@StegSchreck
Copy link
Owner

Hey @Row, Thank you for your contribution!
I will have a closer look at this after work today, but as I'm a fan of the Hacktoberfest as well, I already added the corresponding label so that this PR counts towards your goal.

@StegSchreck StegSchreck added this to the v0.13 milestone Oct 9, 2020
@StegSchreck StegSchreck self-assigned this Oct 9, 2020
@StegSchreck
Copy link
Owner

I actually still see the div#main when I am inspecting the page source at https://www.imdb.com/list/ratings. So I don't see the need for this fix. On the other hand, it has apparently caused issues for other users (see #119).
I wonder if the same change will be made to https://www.imdb.com/profile by the IMDB crew as well in the future. The userid could also be parsed from the URL actually.

@StegSchreck StegSchreck merged commit 6a6c9c3 into StegSchreck:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to locate element: [id="main"]
2 participants