Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract more information from CDF while building the inventory #176

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Jan 15, 2025

closes #162

@jeandet jeandet added the enhancement New feature or request label Jan 15, 2025
@jeandet jeandet added this to the 1.5 milestone Jan 15, 2025
@jeandet jeandet requested a review from brenard-irap January 15, 2025 17:55
Copy link
Collaborator

@brenard-irap brenard-irap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works quite well with the "archive".

But with the cda, DatasetIndex are built from https://spdf.gsfc.nasa.gov/pub/catalogs/all.xml and not from the master file.
It should be nice if we reinject these meta into the DatasetIndex when calling the load_master_cdf method, no?

@jeandet
Copy link
Member Author

jeandet commented Jan 16, 2025

It works quite well with the "archive".

But with the cda, DatasetIndex are built from https://spdf.gsfc.nasa.gov/pub/catalogs/all.xml and not from the master file. It should be nice if we reinject these meta into the DatasetIndex when calling the load_master_cdf method, no?

Sure, I didn't think about the CDA case.

Copy link
Collaborator

@brenard-irap brenard-irap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! THANKS

@jeandet jeandet merged commit 77dde09 into SciQLop:main Jan 16, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve more attributes from CDFs into inventory
2 participants