Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex used to detect an attribute that must be convert to a variable #166

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

brenard-irap
Copy link
Collaborator

This pull request is a fix for issue identified in SciQLop/CDFpp#34.

The regex used to detect an attribute that must be convert to a variable is not sufficiant to support SCAL_PTR, UNIT_PTR and FORM_PTR in writing a CDF/ISTP file.

@brenard-irap brenard-irap force-pushed the fix-cdf-write-ptr-attributes branch from 15fd87f to ba63e79 Compare December 13, 2024 13:17
Copy link
Member

@jeandet jeandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@jeandet jeandet merged commit d1eac57 into SciQLop:main Dec 19, 2024
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants