Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix step-23-filtering-5295470.md #171

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

depth1
Copy link
Contributor

@depth1 depth1 commented Nov 18, 2024

Removing the formatter property in the controller.
The formatter property is not used (even from the associated view) and is assigned a nonexistent value.

It seems that it is a leftover from an old version which no longer has any reason to exist; now formatter modules are directly loaded into the view via sap.ui.core.require.

Removing the formatter property in the controller.
The formatter property is not used (even from the associated view) and is assigned a nonexistent value. 
It seems that it is a leftover from an old version which no longer has any reason to exist; now
formatter modules are directly loaded into the view via sap.ui.core.require.
Copy link

cla-assistant bot commented Nov 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Nov 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OlMue
Copy link
Contributor

OlMue commented Nov 18, 2024

Hi @depth1, thanks for your contribution! We'll look into it and will get back to you.

@KlattG
Copy link
Contributor

KlattG commented Nov 20, 2024

Fixed with the forthcoming UI5 release.

@KlattG KlattG added contribution Valuable Contribution type/examples-samples Related to existing examples/samples, or request for new examples/samples. labels Nov 20, 2024
Copy link

sap-doc-bot bot commented Nov 20, 2024

Thank you for your valuable content contribution, @depth1! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

@KlattG KlattG merged commit 41131e2 into SAP-docs:main Nov 20, 2024
5 checks passed
@depth1
Copy link
Contributor Author

depth1 commented Nov 20, 2024

195835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants