feat: Added business unit field to edit department page #35370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 082a372 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35370 +/- ##
===========================================
- Coverage 59.67% 59.67% -0.01%
===========================================
Files 2826 2826
Lines 68335 68313 -22
Branches 15139 15134 -5
===========================================
- Hits 40781 40764 -17
+ Misses 24941 24937 -4
+ Partials 2613 2612 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
aleksandernsilva
changed the title
lucas-a-pelegrino
previously approved these changes
Mar 7, 2025
MarcosSpessatto
requested changes
Mar 10, 2025
apps/meteor/client/views/omnichannel/departments/utils/formatAgentListPayload.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/omnichannel/omnichannel-monitor-department.spec.ts
Show resolved
Hide resolved
MarcosSpessatto
previously approved these changes
Mar 11, 2025
MartinSchoeler
previously approved these changes
Mar 13, 2025
aleksandernsilva
dismissed stale reviews from MartinSchoeler and MarcosSpessatto
via
9b05ffa
lucas-a-pelegrino
previously approved these changes
Mar 18, 2025
aleksandernsilva
force-pushed
the
feat/department-unit
branch
2 times, most recently
from
0708f18 to
6cfb067
Compare
aleksandernsilva
force-pushed
the
feat/department-unit
branch
from
6cfb067 to
aeeb82d
Compare
renatobecker
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MartinSchoeler
approved these changes
Mar 19, 2025
MarcosSpessatto
approved these changes
Mar 19, 2025
Open
This was referenced Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR adds a new field "Unit" to the new/edit department page.
Before, monitors were able to create new departments, but since the newly created department was not associated with their business unit, they weren't able to access it nor associate afterwards via the units page (monitors usually don't have
manage-livechat-unitspermission). This field allows monitors to specify their unit at the department's creation.Issue(s)
SUP-614
Steps to test or reproduce
Further comments
This feature brought to our attention a legacy gap in the product that we plan on addressing in version 7.6. So for this release we are not going to allow editing the unit field once a department is created.