Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unexpected error when loading webdav files #35257

Merged
merged 11 commits into from
Mar 12, 2025

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Feb 18, 2025

Proposed changes (including videos or screenshots)

Kapture 2025-02-18 at 19 37 17

Issue(s)

Closes #31183

Steps to test or reproduce

  1. Configure a webdav server (you can find instructions here)
  2. Try to open your webdav server
  3. You should be able to see and upload your files properly

Further comments

CORE-996

Copy link
Contributor

dionisio-bot bot commented Feb 18, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: 9f94337

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 7.4.0 milestone Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.65%. Comparing base (5294fed) to head (9f94337).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35257   +/-   ##
========================================
  Coverage    59.64%   59.65%           
========================================
  Files         2828     2828           
  Lines        68533    68528    -5     
  Branches     15192    15188    -4     
========================================
  Hits         40879    40879           
+ Misses       25006    25001    -5     
  Partials      2648     2648           
Flag Coverage Δ
unit 75.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris force-pushed the refactor/getNodeIconType branch from c7b17d0 to 273bed8 Compare February 18, 2025 22:16
Copy link
Contributor

github-actions bot commented Feb 18, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35257/

Built to branch gh-pages at 2025-03-12 14:11 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dougfabris dougfabris changed the title fix: getNodeIconType throwing error for optional parameter fix: Unexpected error when uploading webdav file Feb 18, 2025
@dougfabris dougfabris marked this pull request as ready for review February 18, 2025 22:39
@dougfabris dougfabris requested a review from a team as a code owner February 18, 2025 22:39
@dougfabris dougfabris changed the title fix: Unexpected error when uploading webdav file fix: Unexpected error when loading webdav files Feb 18, 2025
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
@dougfabris dougfabris modified the milestones: 7.4.0, 7.5.0 Feb 20, 2025
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Mar 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 11, 2025
@MartinSchoeler MartinSchoeler removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Mar 11, 2025
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add some tests :)

@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Mar 12, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 12, 2025
@kodiakhq kodiakhq bot merged commit 0919f70 into develop Mar 12, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the refactor/getNodeIconType branch March 12, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebDAV Application Error
3 participants