-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve color contrast in image gallery for WCAG compliance #35233
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: e82be60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35233 +/- ##
========================================
Coverage 59.44% 59.45%
========================================
Files 2828 2828
Lines 68166 68159 -7
Branches 15124 15124
========================================
Hits 40521 40521
+ Misses 24989 24982 -7
Partials 2656 2656
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, I would say this is a feat
- it improves, not fixes... wdyt?
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
d39ab1e
to
9a1ef56
Compare
Proposed changes (including videos or screenshots)
This PR improves the color contrast of icon buttons in the image gallery to ensure compliance with WCAG guidelines. The issue was present in all icon buttons when an image was opened from the chat.
The changes are according to the design
Screen.Recording.2025-02-17.at.5.19.16.PM.mov
Issue(s)
Steps to test or reproduce
Further comments
CORE-816