Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve color contrast in image gallery for WCAG compliance #35233

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Feb 17, 2025

Proposed changes (including videos or screenshots)

This PR improves the color contrast of icon buttons in the image gallery to ensure compliance with WCAG guidelines. The issue was present in all icon buttons when an image was opened from the chat.

The changes are according to the design

Screen.Recording.2025-02-17.at.5.19.16.PM.mov

Issue(s)

Steps to test or reproduce

Further comments

CORE-816

@abhinavkrin abhinavkrin requested a review from a team as a code owner February 17, 2025 12:00
Copy link
Contributor

dionisio-bot bot commented Feb 17, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: e82be60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@abhinavkrin abhinavkrin added this to the 7.4.0 milestone Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.45%. Comparing base (4d6b878) to head (e82be60).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35233   +/-   ##
========================================
  Coverage    59.44%   59.45%           
========================================
  Files         2828     2828           
  Lines        68166    68159    -7     
  Branches     15124    15124           
========================================
  Hits         40521    40521           
+ Misses       24989    24982    -7     
  Partials      2656     2656           
Flag Coverage Δ
unit 75.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@juliajforesti juliajforesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I would say this is a feat - it improves, not fixes... wdyt?

Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
@abhinavkrin abhinavkrin force-pushed the fix/image-gallery-wcag-contrast-issues branch from d39ab1e to 9a1ef56 Compare February 19, 2025 08:17
@abhinavkrin abhinavkrin changed the title fix: color contrast issues in image gallery for WCAG compliance feat: improve color contrast in image gallery for WCAG compliance Feb 19, 2025
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Feb 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 19, 2025
@kodiakhq kodiakhq bot merged commit 69e0d90 into develop Feb 19, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the fix/image-gallery-wcag-contrast-issues branch February 19, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants