Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rooms not working in embedded layout #35204

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Feb 13, 2025

Proposed changes (including videos or screenshots)

Issue introduced here #33898

Issue(s)

CORE-988

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner February 13, 2025 22:42
Copy link
Contributor

dionisio-bot bot commented Feb 13, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: f36bc5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gabriellsh gabriellsh added this to the 7.4.0 milestone Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (1a37e2d) to head (f36bc5c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35204   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2827     2827           
  Lines        68162    68162           
  Branches     15123    15123           
========================================
  Hits         40516    40516           
  Misses       24990    24990           
  Partials      2656     2656           
Flag Coverage Δ
unit 75.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Feb 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 17, 2025
@kodiakhq kodiakhq bot merged commit 407da81 into develop Feb 18, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the fix/embeddedLayoutSub branch February 18, 2025 11:54
@scuciatto
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Feb 18, 2025

Pull request #35251 added to Project: "Patch 7.3.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants