Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Adding InputType enum #540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djarecka
Copy link
Member

the input types added from input selector

@yibeichan - We should add some meaningful description, is it a place that it exists?

Comment on lines +697 to +724
audioCheck:
title: audioCheck
description: An audio check input type.
meaning: reproschema:audioCheck
audioRecord:
title: audioRecord
description: An audio record input type.
meaning: reproschema:audioRecord
audioPassageRecord:
title: audioPassageRecord
description: An audio passage record input type.
meaning: reproschema:audioPassageRecord
audioImageRecord:
title: audioImageRecord
description: An audio image record input type.
meaning: reproschema:audioImageRecord
audioRecordNumberTask:
title: audioRecordNumberTask
description: An audio record number task input type.
meaning: reproschema:audioRecordNumberTask
audioRecordAudioTask:
title: audioRecordAudioTask
description: An audio record audio task input type.
meaning: reproschema:audioRecordAudioTask
audioRecordNoStop:
title: audioRecordNoStop
description: An audio record no stop input type.
meaning: reproschema:audioRecordNoStop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this coming from schemas and protocols? or from the UI itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just copied everything what is in the UI in the selector.
I don't think the list was ever in schema, just trying to add

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see. this is fine for now. we may want to consolidate in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this is also why I think we should provide better description and check if this still make sense and work

@yibeichan
Copy link
Contributor

@djarecka this one looks good, oh, the matrixInfo issue, I probably linked it to the wrong PR, it should be related to a different PR.
we can add more informative descriptions, maybe we should add it to reproschema documentation/website?

@djarecka
Copy link
Member Author

@ibevers - I talked to @yibeichan and she said that you might be the best person to provide some useful description for the input types that the ui supports. Have you used all/most of the types I listed? Could you help with the descriptions and perhaps with testing the ones that haven't been used recently to check if they still behave correctly?

@ibevers
Copy link

ibevers commented Feb 5, 2025

@djarecka I think I've only used 2-3 of the listed input types. I'm not sure exactly what the correct behavior should be for most of them. I think this could be a good task for Veronika since she is more familiar with JavaScript and the UI.

@djarecka
Copy link
Member Author

djarecka commented Feb 5, 2025

@ibevers - I think it would be really nice to test and know the other input options that we have in reproschema-ui.
I'm guessing that some of them can be pretty obvious to see if they work once you try them. Can I ask you and @Veronika271 to give it a try?

@ibevers
Copy link

ibevers commented Feb 6, 2025

@ibevers - I think it would be really nice to test and know the other input options that we have in reproschema-ui. I'm guessing that some of them can be pretty obvious to see if they work once you try them. Can I ask you and @Veronika271 to give it a try?

@djarecka I'm busy with other projects at the moment, but I'm happy to answer any questions @Veronika271 has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants