Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports React 18 #2033

Closed
wants to merge 1 commit into from
Closed

Supports React 18 #2033

wants to merge 1 commit into from

Conversation

Mokto
Copy link

@Mokto Mokto commented May 31, 2022

What/Why/How?

npm install crashes right if using version 18

@Mokto Mokto requested a review from a team as a code owner May 31, 2022 14:48
@Mokto Mokto requested review from AlexVarchuk and anastasiia-developer and removed request for a team May 31, 2022 14:48
@AlexVarchuk
Copy link
Collaborator

@Mokto Hi! Thank you for your contribution.
Does it work with React.StrictMode? Details you can check here

@Mokto
Copy link
Author

Mokto commented May 31, 2022

Works perfectly with & without it.

In my case at least. Using the RedocStandalone component.

@Mokto
Copy link
Author

Mokto commented May 31, 2022

Note: i used npm install --force to force react 18.

@AlexVarchuk
Copy link
Collaborator

Hi @Mokto. I tested it with React.StrictMode and it still have problems:

  • doesn't show the left panel
  • the right pane is not displayed correctly

Screenshot 2022-06-01 at 15 29 18

It reproduced with CRA.

Can you provide details of your testing flow?
Thanks

@AlexVarchuk AlexVarchuk mentioned this pull request Sep 13, 2022
@AlexVarchuk
Copy link
Collaborator

We appreciate your contribution, but this PR is not added full support for React 18.
We created the issue for that.

@AlexVarchuk AlexVarchuk mentioned this pull request Jul 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants