refactored with new design for resource images, stacks, nics, pips #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkarkhatavkar
force-pushed
the
resource_refactor
branch
from
cf3e4ba to
c9811dd
Compare
omkarkhatavkar
force-pushed
the
resource_refactor
branch
from
c9811dd to
e578681
Compare
jyejare
approved these changes
Jun 20, 2024
Not in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Moved Cleanup Implementation: Instead of implementing each cleanup method directly in the cleanup() function, I've abstracted the cleanup logic into separate classes. Each cleanup type (e.g., Pips, NICs, Images) now has its own class with a cleanup() method. This follows the principle of separation of concerns and improves code organization.