Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd: use rasactl to operate models #663

Merged
merged 19 commits into from
Nov 19, 2021
Merged

cd: use rasactl to operate models #663

merged 19 commits into from
Nov 19, 2021

Conversation

HotThoughts
Copy link
Contributor

Fix #657

@HotThoughts
Copy link
Contributor Author

HotThoughts commented Nov 9, 2021

@tczekajlo tag you here because you know rasactl the best. Have you seen this error before?

Error: Post "https://***/api/projects/default/models": http2: server sent GOAWAY and closed the connection; LastStreamID=5, ErrCode=ENHANCE_YOUR_CALM, debug=""

Is it about the header field size for http2 configured on nginx server?


Update:

This error is caused by the fact that Rasa X instance does not support http2.

Fixed adb5582

@HotThoughts HotThoughts marked this pull request as ready for review November 16, 2021 14:30
@HotThoughts HotThoughts changed the title cd: use rasactl cd: use rasactl to operate models Nov 16, 2021
@HotThoughts
Copy link
Contributor Author

@tczekajlo @melindaloubser1

💫 Ready for review. See this successful run. I am so happy that rasactl worked here. Love it.

Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one Q about what the ns line is for, otherwise glad it works !

@HotThoughts HotThoughts merged commit 67732e3 into main Nov 19, 2021
@HotThoughts HotThoughts deleted the fix-cd branch November 19, 2021 09:03
hamzaziizzz pushed a commit to hamzaziizzz/rasa-demo that referenced this pull request Aug 10, 2024
* Use rasactl to upload model

* tmp: enable deployment for testing

* Add helm release name

* update syntax

* Debug

* Upgrade helmfile to v0.141.0

* Update env var syntax

* Add label to k8s namespace

* Do not pass helm release name

* handle the case where namespace is already labeled

* Trick

* Handle the case where secret does not set

* debug

* Disable http2client

* Clean ns label

* Move tag model

* Refactoring a bit

* Revert "tmp: enable deployment for testing"

This reverts commit 9118192.

* Update .github/workflows/continuous_deployment.yml

Co-authored-by: Melinda Loubser <[email protected]>

Co-authored-by: Tomasz Czekajlo <[email protected]>
Co-authored-by: Melinda Loubser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cd: investigate model uploading issue
3 participants