Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test both NLU and Core in Test End 2 End Strories #651

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Test both NLU and Core in Test End 2 End Strories #651

merged 4 commits into from
Jun 22, 2022

Conversation

hsm207
Copy link
Contributor

@hsm207 hsm207 commented Aug 27, 2021

Update CI command for testing stories to include NLU (it was explicitly doing test core)

@hsm207 hsm207 requested a review from indam23 August 27, 2021 10:30
Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!🚀

@hsm207
Copy link
Contributor Author

hsm207 commented Aug 27, 2021

@melindaloubser1 the test_action_community_events is failing because get_community_events threw an exception at:

events = soup.find("ul", attrs={"id": "events-list"}).find_all("li")

The page used to get the events is:

COMMUNITY_EVENT_PAGE = "https://rasa.com/community/join/"

I think the page may have been updated and the list of events have been moved elsewhere.

@indam23
Copy link
Contributor

indam23 commented Aug 27, 2021

Yes, this showed up on another PR and I haven't had a chance to inspect it yet. If you do have the time, we probably need to update how elements are pulled from the page to match the new schema.

@hsm207
Copy link
Contributor Author

hsm207 commented Aug 27, 2021

The list of events is gone.

Before:

image

Now:

image

Not sure if it is because we have to upcoming events or if the list of events have been moved elsewhere. Who can we check about this?

@HotThoughts
Copy link
Contributor

Have you tested rasa test --stories tests/test_conversations.yml --fail-on-prediction-errors locally?

I am asking this because I tried to do the same thing for rasa-train-test-gha but rasa test could not pick up the right stories when testing core.

I ended up run rasa test nlu and rasa test core --stories tests/test_conversations.yml --fail-on-prediction-errors separately.

Seems like rasa test does not accept core and nlu argument, although their arguments are two disjoint sets. 👐

@indam23 indam23 enabled auto-merge February 16, 2022 14:56
@indam23 indam23 disabled auto-merge June 22, 2022 09:31
@indam23 indam23 merged commit b640e1b into main Jun 22, 2022
hamzaziizzz pushed a commit to hamzaziizzz/rasa-demo that referenced this pull request Aug 10, 2024
Test both NLU and Core in Test End 2 End Strories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants