Re-sync with upstream, fix BitCast noise #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update after llvm-project commit `979c275097a6 ("[IR] Store Triple in
Module (NFC) (#129868)", 2025-03-06)`.
… -1) (#3036) Corrected sunormal checking logic in is_fpclass intrinsic issubnormal(V) ==> unsigned(abs(V) - 1) < (all mantissa bits set) corrected the testfile to check the corrected logic
…(#3050) Instead of checking that the image operands are equal to the LOD mask, check that the LOD bit is in the image operands. This way an LOD value of zero may be ignored even when image operands contains bits other than the LOD bit, such as for the SPIR-V 1.6 nontemporal image operand. fixes #3049
llvm-spirv.cpp was relying on transitive includes for these. Also remove an unneeded `<set>` include.
Signed-off-by: Arvind Sudarsanam <[email protected]>
Update the pattern after llvm-project commit da0f9e75d858 ("Reland: [MC]
output inlined-at debug info (#106230) (#130306)", 2025-03-11).
searlmc1
added a commit
that referenced
this pull request
Mar 13, 2025
* Absorb upstream carnage around `Triple`. (#6) * Re-sync with upstream, fix BitCast noise (#7) * Update after llvm::Triple changes (#3046) Update after llvm-project commit `979c275097a6 ("[IR] Store Triple in Module (NFC) (#129868)", 2025-03-06)`. * Corrected subnormal checking logic issubnormal(V) ==> unsigned(abs(V) -1) (#3036) Corrected sunormal checking logic in is_fpclass intrinsic issubnormal(V) ==> unsigned(abs(V) - 1) < (all mantissa bits set) corrected the testfile to check the corrected logic * properly handle LOD values when nontemporal image operand is present (#3050) Instead of checking that the image operands are equal to the LOD mask, check that the LOD bit is in the image operands. This way an LOD value of zero may be ignored even when image operands contains bits other than the LOD bit, such as for the SPIR-V 1.6 nontemporal image operand. fixes #3049 * [NFC] Add some missing includes (#3045) llvm-spirv.cpp was relying on transitive includes for these. Also remove an unneeded `<set>` include. * Emit error for LLVM bfloat type (#3047) Signed-off-by: Arvind Sudarsanam <[email protected]> * Update DebugInfo test after LLVM change (#3060) Update the pattern after llvm-project commit da0f9e75d858 ("Reland: [MC] output inlined-at debug info (#106230) (#130306)", 2025-03-11). --------- Signed-off-by: Arvind Sudarsanam <[email protected]> Co-authored-by: Sven van Haastregt <[email protected]> Co-authored-by: sumesh-s-mcw <[email protected]> Co-authored-by: Ben Ashbaugh <[email protected]> Co-authored-by: Arvind Sudarsanam <[email protected]> --------- Signed-off-by: Arvind Sudarsanam <[email protected]> Co-authored-by: Alex Voicu <[email protected]> Co-authored-by: Sven van Haastregt <[email protected]> Co-authored-by: sumesh-s-mcw <[email protected]> Co-authored-by: Ben Ashbaugh <[email protected]> Co-authored-by: Arvind Sudarsanam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.