Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Ternary Folding during SSA #1998

Merged
merged 4 commits into from
Aug 5, 2022
Merged

[Fix] Ternary Folding during SSA #1998

merged 4 commits into from
Aug 5, 2022

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Aug 5, 2022

This PR fixes a bug in SSA associated with ternary folding for early return statements.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #1998 (e4db551) into testnet3 (7ffbee2) will decrease coverage by 0.05%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##           testnet3    #1998      +/-   ##
============================================
- Coverage     81.08%   81.02%   -0.06%     
============================================
  Files           131      131              
  Lines          5534     5534              
  Branches       5533     5533              
============================================
- Hits           4487     4484       -3     
- Misses         1047     1050       +3     
Impacted Files Coverage Δ
compiler/ast/src/expressions/ternary.rs 62.50% <0.00%> (ø)
...static_single_assignment/static_single_assigner.rs 92.42% <ø> (ø)
...ses/src/static_single_assignment/rename_program.rs 92.00% <100.00%> (ø)
compiler/ast/src/common/identifier.rs 88.88% <0.00%> (-11.12%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bendyarm
Copy link
Collaborator

bendyarm commented Aug 5, 2022

This works on my example, thanks!

@d0cd d0cd requested a review from collinc97 August 5, 2022 17:30
@d0cd d0cd merged commit e7f1833 into testnet3 Aug 5, 2022
@d0cd d0cd deleted the fix/ssa-folded-returns branch August 5, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants