chore: send survey partial responses event #1788
Draft
+81
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasheriques
added
bump patch
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +4.25 kB (+0.12%) Total Size: 3.56 MB
ℹ️ View Unchanged
|
marandaneto
reviewed
Mar 7, 2025
| if (!posthog) { | ||
| logger.error('[survey sent] event not captured, PostHog instance not found.') | ||
| return | ||
| } | ||
| localStorage.setItem(getSurveySeenKey(survey), 'true') | ||
|
|
||
| // Don't send partial response if survey is not completed and disable_survey_partial_response is true |
There was a problem hiding this comment.
will disable_survey_partial_response be default'ed to false? or should that be an opt in feature?
marandaneto
reviewed
Mar 7, 2025
| @@ -684,6 +684,10 @@ export function SurveyPopup({ | |||
| onPopupSurveyDismissed = () => {}, | |||
| onPopupSurveySent = () => {}, | |||
| }: SurveyPopupProps) { | |||
| const surveyResponseInsertID = useMemo( | |||
marandaneto
reviewed
Mar 7, 2025
Comment on lines
+688
to
+689
| () => survey.id + Math.random().toString(36).substring(2, 10) + Math.random().toString(36).substring(2, 10), | ||
| [survey.id] |
There was a problem hiding this comment.
can we just use an uuid instead?
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
sends events after every survey question - logic to dedupe them will be done on posthog/posthog side
related issue: PostHog/posthog#19300
todo:
Checklist