SQLAlchemy 1.4 #12
Merged
SQLAlchemy 1.4 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
bouttier
commented
Nov 9, 2023
src/pypn_habref_api/models.py
Outdated
| @@ -126,4 +126,5 @@ class AutoCompleteHabitat(DB.Model): | |||
| primaryjoin=(cor_list_habitat.c.cd_hab == cd_hab), | |||
| secondary=cor_list_habitat, | |||
| secondaryjoin=(cor_list_habitat.c.id_list == BibListHabitat.id_list), | |||
| overlaps="lists", | |||
There was a problem hiding this comment.
Suggested change
| overlaps="lists", | |
| viewonly=True, |
src/pypn_habref_api/models.py
Outdated
| @@ -109,7 +109,7 @@ class BibListHabitat(DB.Model): | |||
| __table_args__ = {"schema": "ref_habitats"} | |||
| id_list = DB.Column(DB.Integer, primary_key=True) | |||
| list_name = DB.Column(DB.Unicode) | |||
| habitats = DB.relationship("Habref", secondary=cor_list_habitat) | |||
| habitats = DB.relationship("Habref", secondary=cor_list_habitat, overlaps="lists") | |||
There was a problem hiding this comment.
Suggested change
| habitats = DB.relationship("Habref", secondary=cor_list_habitat, overlaps="lists") | |
| habitats = DB.relationship("Habref", secondary=cor_list_habitat, back_populates="lists") |
Rajouter également back_populates="habitats" sur la relationship Habref.lists.
src/pypn_habref_api/models.py
Outdated
| @@ -126,4 +126,5 @@ class AutoCompleteHabitat(DB.Model): | |||
| primaryjoin=(cor_list_habitat.c.cd_hab == cd_hab), | |||
| secondary=cor_list_habitat, | |||
| secondaryjoin=(cor_list_habitat.c.id_list == BibListHabitat.id_list), | |||
There was a problem hiding this comment.
Suggested change
| secondaryjoin=(cor_list_habitat.c.id_list == BibListHabitat.id_list), |
Cette condition de join peut être déterminé automatiquement par SQLAlchemy (pas la première car SQLAlchemy s’attend à associé le cd_hab de cor_list_habitat avec Habref.cd_hab et non avec AutoCompleteHabitat.cd_hab).
bouttier
force-pushed
the
feat/update-dependencies
branch
from
fdbb514 to
14cc5b1
Compare
jacquesfize
added a commit
that referenced
this pull request
Jan 29, 2024
* init branch + change models for SQLA 1.4 * ci: remove Debian 10, add Debian 12 --------- Co-authored-by: Pierre Narcisi <[email protected]> Co-authored-by: Jacques Fize <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.