Replace notify-send with dunstify #2
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dunstify allows for --replace option to replace notification in places. Add --appname option for proper dunstrc configuration.
|
Thank you for your pull request. I believe that some—if not many—users do not have dunst installed because they use Gnome or KDE; thus calling dunstify would cause an error for them. |
Parranoh
reviewed
Jul 11, 2024
| @@ -1,16 +1,22 @@ | |||
| local utils = require "mp.utils" | |||
|
|
|||
| local cover_filenames = { "cover.png", "cover.jpg", "cover.jpeg", | |||
| "folder.jpg", "folder.png", "folder.jpeg", | |||
| "AlbumArtwork.png", "AlbumArtwork.jpg", "AlbumArtwork.jpeg" } | |||
There was a problem hiding this comment.
AlbumArtwork.* are lost. Is this intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dunstify allows for --replace option to replace notification in place.
Add --appname option for proper dunstrc configuration.
Add more filenames.