Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sponsored by ARK] Encryption #24489

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

patrikpordi
Copy link
Contributor

@patrikpordi patrikpordi commented Mar 11, 2025

Solved Problem

Making creating encrypted board files and then log download and decryption easier

Solution

Creating scripts to generate keys, dowload the logs and then decrypt them

Context

Refer to README.md

@patrikpordi
Copy link
Contributor Author

@dakejahl @AlexKlimaj

Copy link
Contributor

@dakejahl dakejahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put these new scripts in their own dir, maybe Tools/log_encryption/. Let's also add a README to this new dir that explains how to use

Copy link
Contributor

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing about these scripts that says they are not generally useful. So when this merges, can you update https://docs.px4.io/main/en/dev_log/log_encryption.html ?

@dakejahl
Copy link
Contributor

Rather than create a new file with a new name decrypt_logs.py why don't we update the existing decrypt_ulog.py?

Adjusted the log downloader to handle multiple entry responses from the FC
Edited README
@AlexKlimaj AlexKlimaj changed the title Encryption - ARK [Sponsored by ARK] Encryption Mar 17, 2025
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-mar-19-2025/44414/4

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-mar-19-2025/44414/1

@patrikpordi
Copy link
Contributor Author

@jlaitine I heard that you originally implemented encryption for logs. Could you take a look at this PR to ensure it doesn’t interfere with your work? I’ve just made it more user-friendly by adding some scripts that make it accessible to non-developers.

@hamishwillee
Copy link
Contributor

hamishwillee commented Mar 20, 2025

@jnomikos might also be a good person to ask. He just updated the docs on log encryption.

Note, @patrikpordi also please check and update the docs if needed to match this. Docs are now maintained in the /docs tree in this repo.

@jlaitine
Copy link
Contributor

@jlaitine I heard that you originally implemented encryption for logs. Could you take a look at this PR to ensure it doesn’t interfere with your work? I’ve just made it more user-friendly by adding some scripts that make it accessible to non-developers.

Looks good to me :)

@mrpollo
Copy link
Contributor

mrpollo commented Mar 20, 2025

thanks @jlaitine !

patrikpordi added a commit to patrikpordi/PX4-Autopilot that referenced this pull request Mar 20, 2025
patrikpordi added a commit to patrikpordi/PX4-Autopilot that referenced this pull request Mar 20, 2025
patrikpordi added a commit to patrikpordi/PX4-Autopilot that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants