-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sponsored by ARK] Encryption #24489
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put these new scripts in their own dir, maybe Tools/log_encryption/. Let's also add a README to this new dir that explains how to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing about these scripts that says they are not generally useful. So when this merges, can you update https://docs.px4.io/main/en/dev_log/log_encryption.html ?
Rather than create a new file with a new name |
Adjusted the log downloader to handle multiple entry responses from the FC Edited README
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
@jlaitine I heard that you originally implemented encryption for logs. Could you take a look at this PR to ensure it doesn’t interfere with your work? I’ve just made it more user-friendly by adding some scripts that make it accessible to non-developers. |
@jnomikos might also be a good person to ask. He just updated the docs on log encryption. Note, @patrikpordi also please check and update the docs if needed to match this. Docs are now maintained in the /docs tree in this repo. |
Looks good to me :) |
thanks @jlaitine ! |
Solved Problem
Making creating encrypted board files and then log download and decryption easier
Solution
Creating scripts to generate keys, dowload the logs and then decrypt them
Context
Refer to README.md