Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: introduce px4-dev container with multi arch support #24022

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

mrpollo
Copy link
Contributor

@mrpollo mrpollo commented Nov 22, 2024

Use the px4-dev container to build and publish all targets

  • builds x86, and arm64 px4-dev images
    • conditional to changes in either ubuntu.sh or requirements.txt
  • updates ubuntu.sh for installing under both architectures
  • fixes a stringop-overflow issue with gcc > 12
  • uses the px4-dev container to build the build matrix of all boards

@PX4 PX4 deleted a comment from github-actions bot Nov 22, 2024
@PX4 PX4 deleted a comment from github-actions bot Nov 22, 2024
@mrpollo mrpollo force-pushed the mrpollo/build_with_dev_container branch 2 times, most recently from 24ede0c to 93b6f72 Compare November 22, 2024 02:33
@PX4 PX4 deleted a comment from github-actions bot Nov 22, 2024
@PX4 PX4 deleted a comment from github-actions bot Nov 22, 2024
@PX4 PX4 deleted a comment from github-actions bot Nov 22, 2024
@PX4 PX4 deleted a comment from github-actions bot Nov 22, 2024
@PX4 PX4 deleted a comment from github-actions bot Nov 22, 2024
@PX4 PX4 deleted a comment from github-actions bot Nov 22, 2024
@PX4 PX4 deleted a comment from github-actions bot Nov 22, 2024
@github-actions github-actions bot added the stale label Dec 23, 2024
@dagar dagar removed the stale label Feb 18, 2025
@alexcekay
Copy link
Member

alexcekay commented Feb 18, 2025

Hi @dagar and @mrpollo,
thanks for the effort 👍

Regarding the compiler errors you guys are facing. I had the same ones when trying to use the Noble containers I created in PX4.

  • Dangling Pointers
  • Stringop Overflow

I had a look at the relevant code and they are false positives. I solved it by ignoring the specific false positives in the relevant files.

For the Dangling Pointers:

For Stringop Overflow:

Regarding the last failed run you posted: This seems like curl is not installed in the image.

@mrpollo mrpollo force-pushed the mrpollo/build_with_dev_container branch 5 times, most recently from 6a3204f to 0fe5fe9 Compare March 3, 2025 18:58
@mrpollo mrpollo marked this pull request as ready for review March 3, 2025 19:19
@mrpollo mrpollo requested a review from dagar March 3, 2025 19:20
@mrpollo
Copy link
Contributor Author

mrpollo commented Mar 3, 2025

thanks for the fix @alexcekay I pushed a commit to the libdronecan lib for the stringop-overflow error, however the remaining failures are not present anymore, hopefully it means they got fixed elsewhere!

@mrpollo mrpollo force-pushed the mrpollo/build_with_dev_container branch 4 times, most recently from 22512aa to 94a4697 Compare March 4, 2025 18:52
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-mar-05-2025/44169/5

mrpollo added 20 commits March 13, 2025 14:36
this is needed for the runs-on s3 special cache
https://runs-on.com/caching/magic-cache/
Signed-off-by: Ramon Roche <[email protected]>
Signed-off-by: Ramon Roche <[email protected]>
pushes amd64 and arm64 images, then mixes in a next step
Signed-off-by: Ramon Roche <[email protected]>
Signed-off-by: Ramon Roche <[email protected]>
Signed-off-by: Ramon Roche <[email protected]>
Signed-off-by: Ramon Roche <[email protected]>
Signed-off-by: Ramon Roche <[email protected]>
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-mar-19-2025/44414/1

@mrpollo mrpollo marked this pull request as draft March 19, 2025 17:24
@mrpollo
Copy link
Contributor Author

mrpollo commented Mar 19, 2025

moving to draft as i am still figuring out the best approach to building the multi platform images in ci

@afwilkin
Copy link
Contributor

@mrpollo
Copy link
Contributor Author

mrpollo commented Mar 24, 2025

Wonderful thanks for the testing @afwilkin LMK when you have logs for the other platforms

@afwilkin
Copy link
Contributor

afwilkin commented Mar 25, 2025

Noting on here that the "actuator tab" for the NXP FCU is a bit messed up
https://www.loom.com/share/882d61a714554ba5bc06d10cdeb6e422
image

Oh, it appears that all pins are aux 1-12.

In mainline we disabled the auto-assigning of motors 1-4 for the main pins...so this should be fine once merged in mainline

@afwilkin
Copy link
Contributor

afwilkin commented Mar 25, 2025

ESC calibration failing:
https://www.loom.com/share/882d61a714554ba5bc06d10cdeb6e422
Although this is on QGC stable. Not sure about main

@afwilkin
Copy link
Contributor

@mrpollo The only thing that was an issue was the ESC calibration failing: #24022 (comment)

we will need to flash stable and 1.16 beta to narrow down the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants