Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
LOCI
map_blocks
foradd_dims
inGrouper
#818bumpversion (major / minor / patch)
has been called on this branchgit push --tags
).zenodo.json
What kind of change does this PR introduce?
thresh
is now a Quantity string, as it should be after Update history, refactor sdba processing functions, add unit handling in sdba #801._loci_train
function is now wrapped correctly to reduce dimensions passed inGrouper.add_dims
, as it should have been in [sdba] Optimizations and fixes #791.sdba.utils._ecdf_1d
reduces along all dimensions, to allow the use ofGrouper.add_dims
with LOCI.Does this PR introduce a breaking change?
No
Other information:
An announcement about
Grouper.add_dims
was added to the history.