Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated functions, deprecate testing.open_dataset #2139

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Mar 31, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Removes the deprecated sfcwind_2_uas_vas and uas_vas_2_sfcwind converter functions.
  • Adds a deprecation notice to xclim.testing.open_dataset to be removed in a future version

Does this PR introduce a breaking change?

Yes. Functions that were previously deprecated have been removed. Suggestions have been made to use the nimbus class to manage fetching testing data.

@Zeitsperre Zeitsperre added the standards / conventions Suggestions on ways forward label Mar 31, 2025
@Zeitsperre Zeitsperre added this to the v0.57.0 milestone Mar 31, 2025
@Zeitsperre Zeitsperre self-assigned this Mar 31, 2025
@github-actions github-actions bot added the indicators Climate indices and indicators label Mar 31, 2025
@Zeitsperre Zeitsperre requested review from aulemahal and coxipi April 1, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
indicators Climate indices and indicators standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant