Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: add README.md and LICENSE.TXT for icons #5387

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

neteler
Copy link
Member

@neteler neteler commented Mar 14, 2025

This PR adds a README.md containing author @Cracert, license and source of icon files.

Also adding LICENSE.TXT as required by icon license.

This PR adds a `README.md` containing author @Cracert, license and source of icon files.

Also adding `LICENSE.TXT` as required by icon license.
@neteler neteler added GUI wxGUI related backport to 7.8 PR needs to be backported to release branch 7.8 backport to 8.4 PR needs to be backported to release branch 8.4 labels Mar 14, 2025
@neteler neteler added this to the 8.5.0 milestone Mar 14, 2025
@neteler neteler requested a review from echoix March 14, 2025 13:34
@github-actions github-actions bot added docs markdown Related to markdown, markdown files labels Mar 14, 2025
@nilason
Copy link
Contributor

nilason commented Mar 14, 2025

The licence file looks like html, not txt (https://github.com/Cracert/GIS-icons/blob/master/LICENSE.TXT)

@neteler
Copy link
Member Author

neteler commented Mar 14, 2025

Ouch, fixed.

@echoix
Copy link
Member

echoix commented Mar 14, 2025

Do we need to copy the license file in the built software?

@neteler
Copy link
Member Author

neteler commented Mar 17, 2025

The license statement is "I only ask you to let me know about that and to include licence.txt file in your work."

So, sounds like "to be included" - however, @Cracert may decide.

LICENSE

Original GIS icons theme was created by Robert Szczepanek [1] and is licensed under a Creative Commons Attribution-Share Alike 3.0 Unported License [2].
Fill free to use it for GIS software or for any other purposes. I only ask you to let me know about that and to include licence.txt file in your work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fill free to use it for GIS software or for any other purposes. I only ask you to let me know about that and to include licence.txt file in your work.
Feel free to use it for GIS software or for any other purposes. I only ask you to let me know about that and to include licence.txt file in your work.

Copy link
Contributor

@veroandreo veroandreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo

@echoix
Copy link
Member

echoix commented Mar 17, 2025

Small typo

It's written that way in the repo, in the file we need to include. Maybe make that suggestion in his repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 7.8 PR needs to be backported to release branch 7.8 backport to 8.4 PR needs to be backported to release branch 8.4 docs GUI wxGUI related markdown Related to markdown, markdown files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants