Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending the SUMMARY keywords for CO2STORE and H2STORE #6127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daavid00
Copy link
Contributor

@daavid00 daavid00 commented Apr 1, 2025

Depends on OPM/opm-common#4550

Copy link
Member

@totto82 totto82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. IMO this can be merged, but I will give other developers a change to comment (in particular on the addition of has_co2_or_h2store in BlackoilPhases.hpp

@@ -60,6 +60,7 @@ namespace Opm
bool has_foam{};
bool has_brine{};
bool has_zFraction{};
bool has_co2_or_h2store{};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding has_co2_or_h2store is ok I think. Maybe we should consider renaming the BlackoilPhases.hpp at some point.

@bska
Copy link
Member

bska commented Apr 1, 2025

jenkins build this please

1 similar comment
@bska
Copy link
Member

bska commented Apr 1, 2025

jenkins build this please

@daavid00 daavid00 added this to the Release 2025.04 milestone Apr 2, 2025
@daavid00
Copy link
Contributor Author

daavid00 commented Apr 3, 2025

Could this be merged @bska?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants