Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getName phase index for the RPTRST output #6123

Closed
wants to merge 1 commit into from

Conversation

daavid00
Copy link
Contributor

While testing BG and KRG in RPTRST for a GASWATER deck, then this issue came out (e.g., KRG would write the WATKR). This commit fixes this.

@daavid00
Copy link
Contributor Author

jenkins build this please

@totto82 totto82 requested a review from akva2 April 1, 2025 14:55
@akva2
Copy link
Member

akva2 commented Apr 2, 2025

I don't understand how this fixes anything. The phases run over an array that is

(gasPhaseIdx, waterPhaseIdx, oilPhaseIdx), 

which is (0,1,2). This does the same, just with a non-named index ?

@daavid00
Copy link
Contributor Author

daavid00 commented Apr 2, 2025

When writing for all phases then no problem, but when we only would like to write for one phase like described in the first comment, then the issue appears, gasPhaseIdx would be 1 that results in phaseName to be "WAT" (to reproduce this then you can try to run this with RPTRST 'BASIC=2' KRG /)

@akva2
Copy link
Member

akva2 commented Apr 2, 2025

right. that was stupid. better fix in #6134

@daavid00
Copy link
Contributor Author

daavid00 commented Apr 2, 2025

Thanks, then I am closing this.

@daavid00 daavid00 closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants