Modified version of safer well state #6114
Open
+95
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this failure_report please |
GitPaean
reviewed
Mar 27, 2025
| if (well->isProducer() && !zero_target) { | ||
| well->updateWellStateRates(simulator_, this->wellState(), local_deferredLogger); | ||
| //const bool zero_target = well->stoppedOrZeroRateTarget(simulator_, this->wellState(), local_deferredLogger); | ||
| if (well->isProducer()){// && !zero_target) { |
There was a problem hiding this comment.
Here, I think this is the main change of this PR from #5990 . Just putting note for own reference.
GitPaean
reviewed
Mar 27, 2025
| @@ -111,16 +111,29 @@ update(const WellState<Scalar>& well_state, | |||
| if (stop_or_zero_rate_target && seg == 0) { | |||
| value_[seg][WQTotal] = 0; | |||
| } | |||
| assert(ws.initializedFromReservoir()); | |||
There was a problem hiding this comment.
It is because of the if (well->isProducer()){// && !zero_target) { above, it caused many assertion failures, I believe. Because injectors also go here.
atgeirr
force-pushed
the
safer_well_state
branch
2 times, most recently
from
576a5c1 to
60d47cd
Compare
atgeirr
force-pushed
the
safer_well_state
branch
from
60d47cd to
d0f70c6
Compare
|
I think this should be ready now. I have addressed the assert() issue pointed out by @GitPaean above. The major changes are:
|
|
jenkins build this failure_report please |
steink
reviewed
Apr 2, 2025
| { | ||
| assert(isProducer()); |
atgeirr
force-pushed
the
safer_well_state
branch
from
99acb0f to
8a8f761
Compare
Instead of evaluating the well at the state given by its current state (primary variables) use the bhp limit (or 1 bar) to get the rates that provide the correct fractions.
atgeirr
force-pushed
the
safer_well_state
branch
from
8a8f761 to
d791cdc
Compare
|
jenkins build this failure_report please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised and rebased, based on #5990 originally. Removed some changes to simplify investigation.
For now, just for testing.