Trigger WELSPECS Report From Simulator Side #6107
Draft
+131
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on changes in the upstream PR OPM/opm-common#4539. I will keep the PR in a draft state until such time as it is ready for review and merging. |
bska
force-pushed
the
run-welspecs-report-from-writereports
branch
10 times, most recently
from
69f392f to
545c2b3
Compare
|
Tested in Equinor. Results are good and looking forward to seeing this go into master. |
Thank you for testing–this is greatly appreciated! |
bska
force-pushed
the
run-welspecs-report-from-writereports
branch
4 times, most recently
from
c655c13 to
f3434d5
Compare
This achieves two goals
1. It ensures proper sequencing with respect to other PRT file
reports.
2. It simplifies generating WELSPECS reports in restarted
simulation runs.
bska
force-pushed
the
run-welspecs-report-from-writereports
branch
from
f3434d5 to
631ac5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This achieves two goals